Repository navigation
Conversation
planemo 0.75.48 workflow_lint rejects superseded changeset_revisions (IWC-observed pins) for map_param_value, query_tabular, collection_column_join and datamash_ops. Pin each tool version's installable revision instead. See galaxyproject#645. Refs galaxyproject#775. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gxformat2's strict schema rejects a top-level name; label is the format2 field and what the Mold examples already use. Refs galaxyproject#775. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
planemo lint checks tool XML and exits 2 silently on .gxwf.yml; the continue-on-error step hid that. Switch to workflow_lint, skip the best_practices checks (annotation/creator/license don't fit narrow fixtures), report every failing workflow, and make the step gate. Closes galaxyproject#775. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The verification-workflows job linted with
planemo lint, which checks tool XML. On.gxwf.ymlfiles it exits 2 with no message. The step hadcontinue-on-error, so that went unnoticed.workflow_lintturned up real problems, which this PR fixes:changeset_revisionis an installable revision; a non-existent pin survived ten phases #645):map_param_value0.2.0:022a635f2283query_tabular3.3.2:a8e9456dbeadcollection_column_join0.0.3:4b00d89e8690datamash_ops1.9+galaxy0:aaafc0ac4dd2label:instead ofname:. gxformat2's strict schema rejects a top-levelname. The PR useslabel, as the Mold examples already do.planemo workflow_lint --skip best_practices. The best-practice checks (annotation, creator, license) don't fit these narrow fixtures. The step reports every failing workflow and no longer hascontinue-on-error, so a lint failure fails the job.All 31 verification workflows pass the new step locally.
Closes #775.
🤖 Generated with Claude Code