Repository navigation
Add title.xml to .gitignore - #83
Merged
Merged
Conversation
This caught my eye when trying out PackageMaker and running `gap makedoc.g`. It creates `/doc/title.md`. The top five active packages as gleaned from gap-system/gap-packages, all list `/doc/title.md` in their `.gitignore` or ignore the entire contents of the `/doc` folder. This might be conflicting with packages that use GAPDoc without AutoDoc. But for newly created packages, it seems to me to be a sensible default, and a practice that should be advocated
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 67.29% 67.29%
=======================================
Files 9 9
Lines 1006 1006
=======================================
Hits 677 677
Misses 329 329 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caught my eye when trying out PackageMaker and running
gap makedoc.g. It creates/doc/title.md. The top five active packages as gleaned from gap-system/gap-packages, all list/doc/title.mdin their.gitignoreor ignore the entire contents of the/docfolder.This might be conflicting with packages that use GAPDoc without AutoDoc. But for newly created packages, it seems to me to be a sensible default, and a practice that should be advocated