Repository navigation
Make xgap.sh find GAP again - #45
Merged
Merged
Conversation
xgap.sh started `bin/<arch>/gap` in the GAP root directory, a compatibility symlink which GAP 4.13 removed. XGAP then opened its window but never started GAP. Default to the `gap` executable in the GAP root directory, which every supported GAP version provides. Assisted-by: Claude Code (Fable 5.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xgap.shstarted$GAP_DIR/bin/<arch>/gap, a compatibility symlink which GAP 4.13 removed (gap-system/gap commit 04941719f). With a current GAP, XGAP opens its window but never starts GAP, and reports no error.Default to
$GAP_DIR/gapinstead, which every supported GAP version (>= 4.11) provides. An explicitGAP_PRGor-Gis still taken relative to$GAP_DIR/bin.Tested under Xvfb with GAP 4.17dev: before the change a script passed to
xgap.shnever ran, afterwards it does.Assisted-by: Claude Code (Fable 5.1)