Repository navigation
Run the tests inside XGAP from TestPackage as well - #48
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
=======================================
Coverage 49.78% 49.79%
=======================================
Files 28 28
Lines 10302 10302
Branches 558 558
=======================================
+ Hits 5129 5130 +1
Misses 5083 5083
+ Partials 90 89 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fingolfin
added this pull request to stack #49
September 20, 2026 16:41
tst/testall.g, and thus TestPackage("xgap"), never touched the XGAP
executable, so it could not tell whether that was built or works. Let
it also run the tests in tst-gui through the executable, under
xvfb-run if that is installed and else on the X server in DISPLAY.
Without the executable or an X server these tests are skipped with a
message rather than failed: the GAP code of XGAP is also used without
the executable, by Gap.app.
Fixes #4
Assisted-by: Claude Code (Fable 5.1)
fingolfin
force-pushed
the
mh/testall-gui
branch
from
September 20, 2026 16:42
6a30875 to
da17e3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #44; only the last commit belongs to this PR.
tst/testall.g, and thusTestPackage("xgap"), never touched the XGAP executable, so it could not tell whether that was built or works, which is what #4 asks for. It now also runs the tests intst-gui/through the executable: underxvfb-runif that is installed, else on the X server inDISPLAY.Without the executable or an X server these tests are skipped with a message, not failed, because the GAP code of XGAP is also used without the executable (Gap.app). The price is that a broken build still passes
TestPackagesilently on a machine without the executable; making that a failure is a one-line change.Checked locally (macOS, Xvfb via
DISPLAY): all fine gives exit 0 with both test runs executed; a deliberately broken GUI test gives exit 1; no executable and no X server each skip with a message and exit 0. Thexvfb-runbranch could not be tested locally; CI exercises it, as #44 installsxvfb.In CI the GUI tests now run twice, once from
testall.gand once in the separate step that collects coverage.Fixes #4
Assisted-by: Claude Code (Fable 5.1)