Skip to content

kernel: reduce code duplication in SHA256 code #6530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fingolfin merged 1 commit into from
Aug 31, 2026
Merged

kernel: reduce code duplication in SHA256 code #6530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/sha256.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,6 @@ Obj FuncGAP_SHA256_HMAC(Obj self, Obj key, Obj text)
UInt1 k_ipad[64], k_opad[64];
UInt1 digest[32];
sha256_state_t st;
Obj result;

RequireStringRep(SELF_NAME, key);
RequireStringRep(SELF_NAME, text);
Expand Down Expand Up @@ -399,13 +398,7 @@ Obj FuncGAP_SHA256_HMAC(Obj self, Obj key, Obj text)
sha256_update(&st, digest, 32);
sha256_final(&st);

result = NEW_PLIST(T_PLIST, 8);
SET_LEN_PLIST(result, 8);
for (i = 0; i < 8; i++) {
SET_ELM_PLIST(result, i + 1, ObjInt_UInt(st.r[i]));
CHANGED_BAG(result);
}
return result;
return sha256_words(st);
}

// Table of functions to export
Expand Down
Loading