build(deps-dev): prettier 3 + eslint-prettier majors, drop @types/jsdom - #1705
Merged
Merged
Conversation
Combines the three open Dependabot dev-dependency majors: - eslint-plugin-prettier 4.0.0 -> 5.5.6 (#1701). v5 has a peer dependency on prettier >= 3, so prettier moves 2.6.2 -> 3.9.9 alongside it. - eslint-config-prettier 8.5.0 -> 10.1.8 (#1702). - @types/jsdom removed instead of bumped to 30 (#1700). Nothing imports it; it was added in 2018 for a jest setup that no longer uses jsdom types, and jest-environment-jsdom brings its own 16.x copy. v30 also uses syntax that TypeScript 4.9 cannot parse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Output of `npx eslint . --fix` after the prettier 3 upgrade: nested ternary indentation, `as` casts on object literals, and wrapping of long parameter lists. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the three open Dependabot dev-dependency majors with one PR.
ERESOLVEbecause v5 has a peer dependency onprettier >= 3, so prettier also moves 2.6.2 → 3.9.9.jest-environment-jsdom@28brings its own 16.x copy. v30 also uses syntax TypeScript 4.9 can't parse, which you only see if you runtscdirectly..prettierrcalready setstrailingComma: "es5", so prettier 3's new default doesn't apply. The reformat touches 4 files and is in its own commit (style: reformat with prettier 3): indentation of nested ternaries,ascasts on object literals, and wrapping of a long constructor parameter list. No behaviour change.eslint stays on 8.15.0. eslint-plugin-prettier 5 needs eslint >= 8, and eslint-config-prettier 10 needs eslint >= 7, so both are satisfied.
Validation (local)
npm ciandnpm ci --dry-run: clean, no Missing/ERESOLVEnpx eslint .: 0 errors (the 2 existing non-null-assertion warnings are unchanged)make test-ui: 230/230 passedmake build-ui: compiles (only the existing Sass deprecation warnings)Closes #1700, closes #1701, closes #1702.
🤖 Generated with Claude Code