Repository navigation
feat(windows): report host OS context under Wine and Proton - #2241
Open
tustanivsky wants to merge 3 commits into
Open
tustanivsky wants to merge 3 commits into
tustanivsky wants to merge 3 commits into
Conversation
Under Wine, build the OS context from the host via wine_get_host_version and the host os-release read through the Z: drive, in the same shape as the native Linux OS context. Prefer /run/host to report the host instead of the Steam Runtime or Flatpak container.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2241 +/- ##
==========================================
- Coverage 75.63% 75.49% -0.15%
==========================================
Files 103 103
Lines 28263 28329 +66
Branches 5180 5194 +14
==========================================
+ Hits 21378 21387 +9
- Misses 5540 5593 +53
- Partials 1345 1349 +4 🚀 New features to boost your workflow:
|
tustanivsky
marked this pull request as ready for review
October 23, 2026 15:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under Wine and Proton, the OS context currently reports the Windows version that Wine emulates (e.g.
Windows 10.0.19045). This reports the host OS instead, in the same shape as the native Linux OS context, next to thewinecontext added in #1995.wine_get_host_versionexport, and split them intoname,versionandbuildlike on Linuxos-releasethrough theZ:drive for thedistribution_*fields, preferring/run/hostso the host is reported instead of the Steam Runtime or Flatpak containeros-releaseparser between the Linux and Windows codeBehavior change
Under Wine/Proton,
os.namechanges fromWindowstoLinux(orDarwinon macOS hosts), and theos.name/os.versionattributes of logs and metrics change with it. This matches what sentry-godot and sentry-unreal already report via their own OS context overrides, which this PR is meant to replace.The emulated Windows version is no longer reported. If it is useful, it could be added to the
winecontext (e.g.windows_version).Related