Skip to content

fix: keep StreamingReporter#log_error private - #3150

Merged
sl0thentr0py merged 1 commit into
getsentry:masterfrom
sean0407:codex/sentry-ruby-3146-private-log-error
Oct 27, 2026
Merged

sl0thentr0py merged 1 commit into
getsentry:masterfrom
sean0407:codex/sentry-ruby-3146-private-log-error

Conversation

@sean0407

Copy link
Copy Markdown
Contributor

Resolves #3146.

StreamingReporter is prepended to ActionController::Live, but its log_error override was public. That changes the public method set of controllers including ActionController::Live and exposes log_error as an action.

This marks the override private and adds a regression spec that prepends it over a private log_error, then checks the resulting controller method remains private.

Checks performed:

  • Ruby syntax checks for both changed files: passed.
  • Focused RSpec example in an isolated Ruby 3.4 harness with a minimal spec_helper stub: 1 example, 0 failures.
  • Direct Ruby prepend visibility probe: passed.
  • git diff --check: passed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-21T15:01:44.307572Z 6a1117b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sl0thentr0py sl0thentr0py left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @sean0407 !

Co-Authored-By: Codex <noreply@openai.com>
@sl0thentr0py
sl0thentr0py force-pushed the codex/sentry-ruby-3146-private-log-error branch from 6a1117b to 26f60ae Compare October 27, 2026 12:45
@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (7d10c02) to head (26f60ae).
⚠️ Report is 205 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3150      +/-   ##
==========================================
+ Coverage   90.13%   90.88%   +0.74%     
==========================================
  Files         132      154      +22     
  Lines        5301     6360    +1059     
==========================================
+ Hits         4778     5780    +1002     
- Misses        523      580      +57     
Components Coverage Δ
sentry-ruby 97.12% <ø> (-0.17%) ⬇️
sentry-rails 59.32% <ø> (+3.81%) ⬆️
sentry-sidekiq 95.48% <ø> (+0.43%) ⬆️
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.55% <100.00%> (+0.24%) ⬆️
Files with missing lines Coverage Δ
...s/lib/sentry/rails/overrides/streaming_reporter.rb 75.00% <100.00%> (+3.57%) ⬆️

... and 69 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sl0thentr0py
sl0thentr0py merged commit ee50f95 into getsentry:master Oct 27, 2026
157 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StreamingReporter#log_error visibility changed to :public

2 participants