Repository navigation
fix(data-collection): Use frame_context_lines in stacktrace builder - #3158
Merged
Merged
Conversation
StacktraceBuilder still read the deprecated context_lines, so data_collection.frame_context_lines had no effect. Read frame_context_lines instead and backfill it from context_lines= (and from send_default_pii=true) so the legacy option keeps working. Fixes #3157 Co-Authored-By: Neel Shah <6536764+sl0thentr0py@users.noreply.github.com>
sl0thentr0py
approved these changes
Oct 27, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration#stacktrace_builderstill passed the deprecatedcontext_lines, so settingdata_collection.frame_context_lineshad no effect on captured source context.The builder now reads
data_collection.frame_context_lines. To keep the deprecated option working,context_lines=now copies its value intodata_collection, the same wayinclude_local_variables=does.DataCollection.backfillalso copies it on thesend_default_pii = truepath; before, it returned before reaching that line.Fixes #3157
Fixes RUBY-237
via @sl0thentr0py.
--
View Junior Session [Sentry]