Repository navigation
[GHSA-26rh-24rg-j3vv] Goploy: Cross-namespace IDOR and RCE via body-supplied row id in project and project_file handlers - #10640
Conversation
|
Hi there @zhenorzz! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
|
LGTM, confirmed as the maintainer. b49eabe is the fix and it shipped in v1.18.0. |
|
Thank you for confirming, @zhenorzz! If you can, please also submit an Approve review (Files changed → Review changes → Approve) so the curators see it as a formal approval. |
9fd624c
into
zuhairhalawa/advisory-improvement-10640
|
Hi @zuhairhalawa! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future! |
Updates
Comments
Sets the patched version to 1.18.0 (replacing last_affected 1.17.5, which is equivalent: v1.17.5 is the tag immediately before v1.18.0) and adds the fix commit b49eabe9 ("Scope project & project_file lookups by namespace_id"). The commit is contained in the tag v1.18.0 and not in v1.17.5: in v1.17.5 AddFile/Edit/RemoveFile/EditFile use the unscoped GetData(), in v1.18.0 they use GetNamespaceData() with a namespace_id filter.