Repository navigation
[GHSA-vmg4-6gfg-83qx] ApostropheCMS: 2nd-order prototype pollution via PATCH leading to single-request persistent DoS - #10651
Conversation
|
Hi there @boutell! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
boutell
left a comment
There was a problem hiding this comment.
Your description of the change is not accurate. It treats the old and new versions as if both used the "fixed" key. But the old version uses the "last_affected" key, so it is accurate as it stands.
However, "fixed" is more explicit, so we'll accept on that basis.
|
(It looks like I can't merge this, I think the Github Security Curation Team has to do that.) |
bafd358
into
zuhairhalawa/advisory-improvement-10651
|
Hi @zuhairhalawa! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future! |
Updates
Comments
Sets the patched version to 4.32.1 and adds the fix commit 5a3746aa ("Merge commit from fork"; apos.util.get/set now only traverse own properties). The commit is contained in the tag 4.32.1 and not in the previous release 4.32.0 (git tag --contains). The 4.32.1 CHANGELOG names this advisory; 4.32.0 only blocklists proto/constructor/prototype. Releases are cut from a separate line, so the commit is not an ancestor of the tag apostrophe@4.32.1, but util/index.js and test/utils.js in that tag are identical to the commit.