Skip to content

chore: add Astro type checking to local scripts and CI - #773

Merged
setchy merged 1 commit into
mainfrom
chore/add-astro-type-checking
Oct 9, 2026
Merged

setchy merged 1 commit into
mainfrom
chore/add-astro-type-checking

Conversation

@setchy

@setchy setchy commented Oct 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Add pnpm check (astro check) with pinned @astrojs/check, compatible TypeScript 6, and Node 24 declarations.
  • Add an independent Type Check [astro] lint-workflow job on pull requests and pushes to main, using existing pinned actions and least-privilege permissions.
  • Resolve baseline diagnostics with a test parameter annotation and a narrowly scoped Tailwind Motion plugin type assertion for its v3-era declaration mismatch.
  • Document the command and CI behavior; preserve strict checking, existing jobs, build commands, and Netlify configuration.

Validation

  • Clean isolated pnpm install --frozen-lockfile followed by pnpm check, without a prior production build or installation prompt.
  • Separate injected Astro prop and TypeScript assignment errors each produce exit status 1; temporary fixtures removed and baseline passes.
  • pnpm lint:check
  • pnpm test (4 tests passed)
  • pnpm build
  • actionlint 1.7.12 with ShellCheck 0.11.0
  • Verify unchanged workflow triggers, existing jobs, runtime dependencies, strict configuration, and deployment commands.

Existing nonblocking hints/warnings remain: an unused Astro import, deprecated clipboard fallback, SVG accessibility lint warnings, and a mixed static/dynamic image import warning.

Scope

No runtime behavior changes or remote branch-protection changes. OpenSpec change: add-astro-type-checking (planning artifacts are repository-ignored).

@setchy
setchy requested a review from afonsojramos as a code owner October 9, 2026 05:43
@netlify

netlify Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for gitify ready!

Name Link
🔨 Latest commit 9d4a0de
🔍 Latest deploy log https://app.netlify.com/projects/gitify/deploys/6ac87efdd674d100093b788b
😎 Deploy Preview https://deploy-preview-773--gitify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@setchy
setchy merged commit cd97908 into main Oct 9, 2026
14 checks passed
@setchy
setchy deleted the chore/add-astro-type-checking branch October 9, 2026 05:44
@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant