Repository navigation
feat: update biome domains, rules and associated fixes - #782
Merged
Merged
Conversation
Signed-off-by: Adam Setch <adam.setch@outlook.com>
✅ Deploy Preview for gitify ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors across the codebase, focusing on removing the unused
markedmarkdown parser dependency, updating how markdown content is rendered and handled, improving color theming, and enhancing linting configurations. The most significant changes are grouped below.Markdown Rendering and Dependency Removal:
Removed the
markedmarkdown parser from the project, including all related imports and usage inSectionRow.astro, and updatedpackage.jsonandpnpm-lock.yamlto reflect this removal. Markdown content is now rendered using Astro's built-in MDX/Markdown support and slots. [1] [2] [3] [4] [5] [6] [7] [8]Refactored FAQ page (
faq.astro) to use Astro'sMarkdownInstanceand the<Content />component for rendering FAQ markdown, removing the need for manual HTML string manipulation and the external link rewriting function, which is now handled at runtime. [1] [2] [3] [4]UI and Theming Improvements:
Updated color classes across components (e.g.,
LatestRelease.astro,faq.astro) to use newgitify-inkcolor variables for better consistency and dark mode support. [1] [2] [3]Added new
inkcolor palette to the Tailwind CSS configuration for more flexible and semantic color usage.Tweaked animation and rotation classes for the hero image for improved visual effect.
Linting and Code Quality:
biome.jsonlinter configuration by enabling recommended rules for multiple domains and adding stricter rules from the nursery set, improving code quality and consistency.Miscellaneous Fixes:
cachedRequestfunction ingithub.tsto properly check for the existence of thependingproperty.