Skip to content

core, web, docs: require base URL - #26591

Open
emilburzo wants to merge 2 commits into
mainfrom
base-url-required
Open

emilburzo wants to merge 2 commits into
mainfrom
base-url-required

Conversation

@emilburzo

Copy link
Copy Markdown
Member

No description provided.

@emilburzo emilburzo self-assigned this Sep 30, 2026
@emilburzo
emilburzo requested review from a team as code owners September 30, 2026 15:24
@netlify

netlify Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit c8191a6
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/6ac4ad265e25500008748b60
😎 Deploy Preview https://deploy-preview-26591--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.34%. Comparing base (6b5bd3f) to head (c8191a6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26591      +/-   ##
==========================================
+ Coverage   92.33%   92.34%   +0.01%     
==========================================
  Files        1175     1176       +1     
  Lines       77789    77895     +106     
  Branches     4129     4129              
==========================================
+ Hits        71827    71936     +109     
+ Misses       5896     5893       -3     
  Partials       66       66              
Flag Coverage Δ
conformance 32.88% <5.35%> (-0.04%) ⬇️
e2e 37.66% <5.35%> (-0.06%) ⬇️
integration 29.69% <5.35%> (-0.02%) ⬇️
rust 46.45% <ø> (ø)
unit 93.76% <100.00%> (+0.01%) ⬆️
unit-migrate 93.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@emilburzo
emilburzo requested a review from a team as a code owner September 30, 2026 15:48
- name: Start authentik
id: authentik
uses: goauthentik/action-setup-authentik@e9b3782a8da81f3a33bbe21de97c7d3cf6c8820f # v3.2
uses: goauthentik/action-setup-authentik@5b35e5951a1ec761847711a5d8170dbd67675526 # v3.3

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Playwright e2e

Download this run's HTML report and traces, then open the report:

gh run download 37434445152 -D playwright-artifacts
npx playwright show-report playwright-artifacts/playwright-report

Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-c8191a68069ff0ab00cd5e366db5ae723cf7114b
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-c8191a68069ff0ab00cd5e366db5ae723cf7114b

Afterwards, run the upgrade commands from the latest release notes.

@emilburzo emilburzo moved this to Needs review in authentik Core Sep 30, 2026

@BeryJu BeryJu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments otherwise lgtm

Comment thread authentik/core/tests/test_setup.py
def post_startup_require_base_url(sender, **_):
"""Refuse to start an instance that has been set up without a base URL"""
if Setup.get() and not get_system_settings().base_url:
raise ImproperlyConfigured(BASE_URL_REQUIRED)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this error look if the URL isn't set during startup?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crashes with:

server-1  | {"event": "Exception in worker process", "exception": [{"exc_notes": [], "exc_type": "ImproperlyConfigured", "exc_value": "No base URL is configured. Set AUTHENTIK_WEB__BASE_URL to the URL under which authentik is reachable, for example https://authentik.company. See https://docs.goauthentik.io/install-config/configuration/#authentik_web__base_url", "exceptions": [], "frames": [{"filename": "/ak-root/.venv/lib/python3.14/site-packages/gunicorn/arbiter.py", "lineno": 753, "name": "spawn_worker"}, {"filename": "/ak-root/.venv/lib/python3.14/site-packages/gunicorn/workers/base.py", "lineno": 141, "name": "init_process"}, {"filename": "/lifecycle/gunicorn.conf.py", "lineno": 159, "name": "post_worker_init"}, {"filename": "/authentik/root/asgi.py", "lineno": 72, "name": "call_startup"}, {"filename": "/ak-root/.venv/lib/python3.14/site-packages/django/dispatch/dispatcher.py", "lineno": 189, "name": "send"}, {"filename": "/authentik/core/setup/signals.py", "lineno": 59, "name": "post_startup_require_base_url"}], "is_cause": false, "is_group": false, "syntax_error": null}], "level": "error", "logger": "gunicorn.error", "timestamp": "2026-10-05T08:50:29.196530"}
server-1  | No base URL is configured. Set AUTHENTIK_WEB__BASE_URL to the URL under which authentik is reachable, for example https://authentik.company. See https://docs.goauthentik.io/install-config/configuration/#authentik_web__base_url
server-1  | {"event": "Worker exiting (pid: 164)", "level": "info", "logger": "gunicorn.error", "timestamp": "2026-10-05T08:50:29.196742"}

@emilburzo
emilburzo requested a review from BeryJu October 5, 2026 08:53

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

2 participants