[bot] Merge master/782aceef into rel/dev - #1829
Conversation
…dcoded path (#1827) Test fixtures carried metric and label names copied out of one particular workspace, and two comments named an external repository rather than saying what they meant. Neither tells a reader of this package anything: the scoring tests exercise attribute-filter ordering and the names are arbitrary, so they now use generic ones. verify_guardrail_refusal_criteria.py loaded .env from an absolute path under one developer's home directory, which made the script runnable on exactly one machine. It now reads GD_EVAL_ENV_FILE, defaulting to .env in the working directory. One test needed care rather than a rename: the two sides of test_the_same_elements_on_a_different_label_still_differ deliberately name different labels, and renaming both to the same thing quietly turned it into a test of nothing. They stay distinct. No behaviour change. 1111 tests pass. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1829 +/- ##
========================================
Coverage 82.99% 82.99%
========================================
Files 329 329
Lines 21526 21526
========================================
Hits 17866 17866
Misses 3660 3660 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
🚀 Automated PR to perform merge from master into rel/dev with changes up to 782acee (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/35996080924).