You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
bug: error TaskStatusUpdateEvent has final=False in event_converter.py #5388
In src/google/adk/a2a/converters/event_converter.py, the _create_error_status_event function creates a TaskStatusUpdateEvent with final=False when the task has failed:
# event_converter.py line ~464returnTaskStatusUpdateEvent(
task_id=task_id,
context_id=context_id,
metadata=event_metadata,
status=TaskStatus(
state=TaskState.failed,
...
),
final=False, # <-- BUG: should be True for failed state
)
Expected Behavior
When a task has TaskState.failed, the TaskStatusUpdateEvent should have final=True, because error events represent terminal states — no further events will follow.
The existing implementation in from_adk_event.py already handles this correctly:
# from_adk_event.py line ~154error_event=TaskStatusUpdateEvent(
...
final=True, # <-- correct
)
Actual Behavior
Clients/consumers that check the final flag will not know that processing has stopped after a failed status, potentially waiting indefinitely for more events or mishandling the error state.
Fix
Change final=False to final=True in _create_error_status_event in event_converter.py.
Activity
fix(a2a): set final=True for error TaskStatusUpdateEvent in event_con…
kuishou68 commentedon Apr 19, 2026
Fix submitted in PR #5389: #5389
surajksharma07 commentedon Jun 5, 2026
/adk-issue-analyze
surajksharma07 commentedon Jun 9, 2026
/adk-issue-analyze
fix(a2a): set final=True for error TaskStatusUpdateEvent in event_con…
fix(a2a): set final=True for error TaskStatusUpdateEvent in event_con…