Skip to content

fix(tools): support OpenAPI basic auth - #5493

Closed
aashnakunk wants to merge 6 commits into
google:mainfrom
aashnakunk:fix/openapi-basic-auth
Closed

aashnakunk wants to merge 6 commits into
google:mainfrom
aashnakunk:fix/openapi-basic-auth

Conversation

@aashnakunk

@aashnakunk aashnakunk commented Apr 26, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #5493

Summary

  • Add HTTP Basic auth header generation for OpenAPI tools
  • Add unit coverage for Basic auth credentials

Testing

  • .venv/bin/pytest tests/unittests/tools/openapi_tool/auth/test_auth_helper.py

Result:

  • 36 passed, 1 warning in 9.32s

@google-cla

google-cla Bot commented Apr 26, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@adk-bot adk-bot added the tools [Component] This issue is related to tools label Apr 26, 2026
@adk-bot

adk-bot commented Apr 26, 2026

Copy link
Copy Markdown
Collaborator

Response from ADK Triaging Agent

Hello @aashnakunk, thank you for creating this PR!

Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). You can visit https://cla.developers.google.com/ to see your current agreements or to sign a new one.

Also, this PR is a bug fix. Could you please associate the GitHub issue with this PR? If there is no existing issue, could you please create one?

This information will help reviewers to review your PR more efficiently. Thanks!

@rohityan rohityan self-assigned this Apr 27, 2026
@rohityan rohityan added the request clarification [Status] The maintainer need clarification or more information from the author label Apr 27, 2026
@rohityan

Copy link
Copy Markdown
Collaborator

Hi @aashnakunk , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please fix the failing tests before we can proceed with the review.

@aashnakunk

Copy link
Copy Markdown
Contributor Author

Thanks @rohityan ! I pushed a commit to address those failing checks

  • pre-commit on the touched files
  • tests/unittests/tools/openapi_tool/auth/test_auth_helper.py

The workflows now appear to be awaiting maintainer approval! :)

@haranrk haranrk assigned haranrk and unassigned rohityan Jun 17, 2026
copybara-service Bot pushed a commit that referenced this pull request Sep 12, 2026
Merge #5493

Fixes #5492

PiperOrigin-RevId: 980161294
@adk-bot

adk-bot commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

Thank you @aashnakunk for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit f2fe475.

Closing this PR as the changes are now in the main branch.

@adk-bot adk-bot added the merged [Status] This PR is merged label Sep 12, 2026
@adk-bot adk-bot closed this Sep 12, 2026
@GWeale GWeale mentioned this pull request Sep 16, 2026
8 of 9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged [Status] This PR is merged request clarification [Status] The maintainer need clarification or more information from the author tools [Component] This issue is related to tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants