Repository navigation
Fix abseil deprecations (original by alona.moony@gmail.com) - #666
Merged
Merged
Conversation
The original work is by Alona Enraght-Moony <alona.moony@gmail.com> but I'm signing this so it can land. It was PR google#644 and the author signed the Google CLA (verified by the CLA-bot). Author: Alona Enraght-Moony <alona.moony@gmail.com> Date: Mon Jun 29 23:08:33 2026 +0100 Fix abseil lock deprecations Fixes google#631 These were deprecated in abseil/abseil-cpp@6d8e1a5
dneto0
commented
Oct 2, 2026
dneto0
left a comment
dneto0
left a comment
Contributor
Author
There was a problem hiding this comment.
I also retested with a recent copy of abseil-cpp
It passed all the tests I could find:
./re2/regexp_test
./re2/exhaustive3_test
./re2/charclass_test
./re2/filtered_re2_test
./re2/search_test
./re2/random_test
./re2/possible_match_test
./re2/mimics_pcre_test
./re2/set_test
./re2/parse_test
./re2/re2_test
./re2/compile_test
./re2/dfa_test
./re2/exhaustive1_test
./re2/re2_arg_test
./re2/exhaustive_test
./re2/exhaustive2_test
./re2/simplify_test
./re2/required_prefix_test
./re2/string_generator_test
Contributor
Author
|
cc: @adonovan |
Collaborator
|
Many thanks for pushing this over the hump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original work is by Alona Enraght-Moony alona.moony@gmail.com but I'm signing this so it can land.
It was PR #644 and the author signed the Google CLA (verified by the CLA-bot).
Author: Alona Enraght-Moony alona.moony@gmail.com
Date: Mon Jun 29 23:08:33 2026 +0100