Repository navigation
Recognise inherited implementations in Elements.overrides. - #520
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_992334677
branch
from
October 6, 2026 10:49
2d1160d to
6447ef7
Compare
`TurbineElements.overrides` only handled direct overrides, where the overrider's class is a subtype of the overridden method's class. A concrete method that a class inherits from its superclass can also implement an abstract or default method of a superinterface that the superclass doesn't implement (JLS 8.4.8.1), e.g. `AbstractQueue.add(E)` in `LinkedBlockingQueue`. PiperOrigin-RevId: 994295456
copybara-service
Bot
force-pushed
the
test_992334677
branch
from
October 6, 2026 10:59
6447ef7 to
c99f73a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognise inherited implementations in Elements.overrides.
TurbineElements.overridesonly handled direct overrides, where theoverrider's class is a subtype of the overridden method's class. A concrete
method that a class inherits from its superclass can also implement an abstract
or default method of a superinterface that the superclass doesn't implement
(JLS 8.4.8.1), e.g.
AbstractQueue.add(E)inLinkedBlockingQueue.