Skip to content

refactor(subgraph-discovery): move discovery and curation contracts - #1396

Closed
Maikol wants to merge 1 commit into
refactor/contracts-removal-p2-graph-tokenfrom
refactor/contracts-removal-p3-subgraph-discovery
Closed

Maikol wants to merge 1 commit into
refactor/contracts-removal-p2-graph-tokenfrom
refactor/contracts-removal-p3-subgraph-discovery

Conversation

@Maikol

@Maikol Maikol commented Nov 2, 2026

Copy link
Copy Markdown
Member

Moves L2GNS, L2Curation, GNS and their helpers from packages/contracts into packages/subgraph-discovery, and repoints Ignition, pre-verify, Tenderly and deployment at it. Toolshed logs a warning for GraphCurationToken and SubgraphNFTDescriptor, the two new horizon address names. L2GNS (94.38% vs 95.06%) and GNS (68.18% vs 68.55%) read below their coverage baseline because forge counts more lines, and their unhit lines were also unhit by the old tests.

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (8631858) to head (08c3fc0).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           refactor/contracts-removal-p2-graph-token    #1396   +/-   ##
==========================================================================
  Coverage                                      98.74%   98.74%           
==========================================================================
  Files                                             39       39           
  Lines                                           2699     2699           
  Branches                                         477      477           
==========================================================================
  Hits                                            2665     2665           
  Misses                                            13       13           
  Partials                                          21       21           
Flag Coverage Δ
unittests 98.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Maikol

Maikol commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

Replaced by revision 4 of the phase 1 plan: the frozen discovery contracts move to graph-token, and L2GNS and L2Curation are ported in Phase P. The RewardsHook and Multicall tests from this PR are reused in the new P3.

@Maikol Maikol closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant