Repository navigation
Emit notif references - #266
Merged
Merged
Conversation
added 7 commits
August 14, 2026 17:02
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
added 4 commits
August 26, 2026 21:11
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
SlimaneAmar
reviewed
Sep 3, 2026
|
|
||
| private void notifySharedElementHasChanged(DirectoryElementEntity sharedElement, String userId) { | ||
| Map<ReferenceType, List<ReferenceAttributes>> referencesByType = ElementAttributes.toReferencesAttributesByType(sharedElement); | ||
| boolean hasRelevantReference = Stream.of(ReferenceType.STUDY_NODE, ReferenceType.NETWORK_MODIFICATION) |
Contributor
There was a problem hiding this comment.
Is this test really necessary ?
Why only STUDY_NODE and NETWORK_MODIFICATION ?
Map<ReferenceType, List<ReferenceAttributes>> referencesByType = ElementAttributes.toReferencesAttributesByType(sharedElement);
if (referencesByType.values().stream().anyMatch(not(List::isEmpty))) {
notificationService.emitSharedElementChanged(sharedElement.getId(), referencesByType, userId);
}
|
|
||
| @Test | ||
| @SneakyThrows | ||
| void testSharedElementUpdateNotification() { |
Contributor
There was a problem hiding this comment.
Rename by testSharedElementUpdated
|
|
||
| @Test | ||
| @SneakyThrows | ||
| void testElementUpdateNotificationWithoutSharedReferences() { |
Contributor
There was a problem hiding this comment.
Ranme by testElementUpdated
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
Signed-off-by: SOUISSI Maissa (Externe) <souissimai@gm0winl878.bureau.si.interne>
SlimaneAmar
approved these changes
Sep 11, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary