Share a composite modification nested in another composite - #893
Merged
Merged
Conversation
The composite modification is taken out of its own container, the group or a parent composite, which is returned to the caller. A composite containing a shared modification cannot be shared, and whether a composite contains one is exposed by a dedicated endpoint. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 10, 2026
ghazwarhili
reviewed
Sep 11, 2026
Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
ghazwarhili
approved these changes
Sep 14, 2026
The caller needs that reference to register it in the directory server, whether it stands in the group or in a parent composite. The contains-shared-modification endpoint is removed in favour of /containers/references/exists, on which the sharing check now relies. Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
…e modification Signed-off-by: Florent MILLOT <florent.millot_externe@rte-france.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #874.
A composite modification nested in other composites of a group can now be shared. The endpoint now returns the reference left in place of the composite as a
ModificationReferenceData, so that the caller can register it wherever it stands: in the group or in a parent composite.A composite contained by an already shared composite does not belong to the group anymore: sharing it is rejected.
A composite containing a shared modification, at any depth, cannot be shared either: it is rejected with the new
MODIFICATION_CONTAINS_SHAREDbusiness error, relying on the same check asGET /v1/containers/references/exists, which the front uses beforehand to disable the sharing.