Repository navigation
Tell whether a modification reference is editable by its reader - #236
Merged
Merged
Conversation
A modification reference points at a shared modification, which is also an element of the directory: the permission the user holds on it decides what the front-end lets them do with that reference and its content. The permission is read only, never persisted and never read back by a server. It is left null when it was not resolved, which a client must not read as a denial. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
flomillot
requested review from
EtienneLt,
SlimaneAmar and
etiennehomer
as code owners
September 24, 2026 09:37
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
An element the user holds no permission on is answered with no permission at all, which a client must refuse just as it refuses one it could not resolve: the two cases never parted ways, and the value distinguishing them was read by no one. The enum is back to the three the directory knows. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
ghazwarhili
reviewed
Sep 25, 2026
| | `referencedId` | `UUID` | UUID of the referenced modification | | ||
| | `referenceType` | `Type` | `BASIC` or `DIRECTORY` | | ||
| | `referencedInfos` | `ModificationInfos` | Resolved DTO representation | | ||
| | `permission` | `PermissionType` | `READ`, `WRITE` or `MANAGE` : the right the user holds on a shared modification | |
Contributor
There was a problem hiding this comment.
sounds weired (the right... holds on ...)
maybe => the user's permission level for a shared modification
Contributor
Author
There was a problem hiding this comment.
I replaced by the user's permission level on the referenced modification If it's okay.
Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
etiennehomer
requested changes
Sep 29, 2026
Co-authored-by: etiennehomer <etiennehomer@gmail.com>
…sion held The permission levels stay between servers: a client only needs to know whether it may write. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
flomillot
changed the title
etiennehomer
approved these changes
Oct 2, 2026
…nce' into feat/expose-permission-on-reference
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A modification reference now tells whether its reader may write into the shared modification it points at.
The flag is left out when it could not be resolved, which denies the write just the same.
Consumed by gridsuite/network-modification-server.