Repository navigation
[darwin] extractToWav returns incorrect format info for HE-ACC audio - #225
Merged
Merged
Conversation
The decoded format was taken while no PCM had been written yet, which tied it to the byte count. A dedicated flag states the intent, and the comments now say why the track's format is only a fallback for HE-AAC (SBR doubles the rate, PS turns mono into stereo).
Adds a 6 KB, 2 s HE-AAC v2 tone (22.05 kHz mono core, 44.1 kHz stereo decoded) and checks the extracted WAV's length and pitch, full and trimmed. Before the fix the header claimed 22.05 kHz mono, so the WAV lasted 8 s instead of 2 s.
1 task done
Owner
|
Thanks a lot for the fix, @ekuleshov! On top of your change we added a regression integration test with a tiny HE-AAC v2 clip (the old code wrote a WAV claiming 8 s for 2 s of audio) and a small cleanup that tracks the decoded format with its own flag. Testing it on Android also turned up an older bug there, trimmed WAV extractions came out short, which is fixed in #228. This ships in 2.22.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
extractToWav returns incorrect format info for HE-ACC audio on MacOS and iOS
Related Issue: Closes #226
Type of Change