Repository navigation
Flag icon requests for plugins that are not verified - #1306
Merged
Merged
Conversation
The icon request check now reports a request for a plugin that is not on the verified or verified-plus list as needing changes, and labels it awaiting-changes. Its marker still records the request and image as valid, and Icon Approved is unchanged, so a maintainer can approve one as a one-off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1305. The Icon Request Check now reports requests for plugins that aren't verified as needing changes.
Change
Only
.github/workflows/icon-request-check.ymlchanges.preparestep, thecheckjob looks the plugin up inverified-plugins.jsonandverified-plus-plugins.json.awaiting-final-review.awaiting-changes. The comment asks the author to request verification first and to comment/checkonce it's verified. It still shows the plugin, requester, size and icon preview.ok: true, plus a newverifiedfield).icon-approved.ymldoesn't look at verification and isn't changed by this PR, so a maintainer can still approve an icon for a plugin that isn't verified. The run summary says so.Testing
homebridge-my-tadiran, verified), which got ✅ andawaiting-final-review, and on Verification Request: homebridge-pax-calima #1302 (homebridge-pax-calima, not verified), which got ❌ andawaiting-changes.icon-approved.ymlauthorize step, run against mocked GitHub responses, still treated the check as passed.🤖 Generated with Claude Code