Repository navigation
Remove awaiting-final-review when an icon request is closed - #1308
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Icon Approved applies an icon and closes the request, it now also removes
awaiting-final-review, so closed requests no longer look as if they're still waiting for review. For example, #1301 was closed after its icon went in (63a5347) but kept the label.Change
Only the
reportjob in.github/workflows/icon-approved.ymlchanges:awaiting-final-reviewbefore closing the issue. If the label isn't there, it carries on.awaiting-final-reviewand closed the request".Testing
icon-approved, thenawaiting-final-review, then closes.icon-approvedand leaves the request open.🤖 Generated with Claude Code