Skip to content

Remove awaiting-final-review when an icon request is closed - #1308

Merged
NorthernMan54 merged 1 commit into
latestfrom
icon-approved-clear-review-label
Oct 26, 2026
Merged

NorthernMan54 merged 1 commit into
latestfrom
icon-approved-clear-review-label

Conversation

@NorthernMan54

Copy link
Copy Markdown
Contributor

When Icon Approved applies an icon and closes the request, it now also removes awaiting-final-review, so closed requests no longer look as if they're still waiting for review. For example, #1301 was closed after its icon went in (63a5347) but kept the label.

Change

Only the report job in .github/workflows/icon-approved.yml changes:

  • On success: removes awaiting-final-review before closing the issue. If the label isn't there, it carries on.
  • Run summary: now says "Removed awaiting-final-review and closed the request".
  • When the icon isn't applied: unchanged. The request stays open with its labels.

Testing

  • Mocked GitHub responses:
    • Applied: removes icon-approved, then awaiting-final-review, then closes.
    • Label already gone: still closes.
    • Refused: removes only icon-approved and leaves the request open.
  • Lint: ESLint passes.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@NorthernMan54
NorthernMan54 requested a review from bwp91 October 26, 2026 18:15
@NorthernMan54
NorthernMan54 merged commit d91875a into latest Oct 26, 2026
4 checks passed
@NorthernMan54
NorthernMan54 deleted the icon-approved-clear-review-label branch October 26, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant