Repository navigation
TopoCalc - Skew() update - Create new gold reference files - #67
Merged
Merged
Conversation
The `skew` function was updated in topocalc PR#12. This required to create new gold reference files with the different output for the Lakes basin.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arobledano
approved these changes
Mar 9, 2026
Member
Author
|
Note that using a follow up TopoCalc PR (iSnobal/topocalc#15) passes with these updates too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
skewfunction was updated in iSnobal/topocalc#12. This required to create new gold reference files with the different output for the Lakes basin.Unit tests
The unit tests will only pass once the new changes in TopoCalc are officially released (new tag) and the SMRF dependencies updated.
Here the
skewdifferences for the Lakes basin:Before
After
Here how the netCDF gold files changed
Note that the histogram bin-width is 2 W/m^2
Net Solar
Net Solar HRRR