Skip to content

add new icons for fares v2 editor - #1065

Merged
josh-willis-arcadis merged 2 commits into
devfrom
faresv2-icons
Sep 30, 2026
Merged

josh-willis-arcadis merged 2 commits into
devfrom
faresv2-icons

Conversation

@daniel-heppner-ibigroup

Copy link
Copy Markdown
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

Please explain the changes you made here and, if not immediately obvious from the code, how they resolve any referenced issues (and PRs if merging to master). Be sure to include all issues being resolved and any special configuration settings that are need for the software to run properly with these changes.

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense! Sorry for the long delay!

@josh-willis-arcadis josh-willis-arcadis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icons look great. One comment on v2 icon on main sidebar.

Comment thread lib/editor/util/ui.js

@josh-willis-arcadis josh-willis-arcadis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@josh-willis-arcadis
josh-willis-arcadis merged commit 3f346b0 into dev Sep 30, 2026
5 checks passed
@josh-willis-arcadis
josh-willis-arcadis deleted the faresv2-icons branch September 30, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants