Repository navigation
Reduce FMMs for PDE systems - #338
Merged
Merged
Conversation
alexfikl
force-pushed
the
reduce-fmm
branch
2 times, most recently
from
November 13, 2026 08:32
141e14c to
170d6b1
Compare
alexfikl
marked this pull request as ready for review
November 13, 2026 15:46
There was a problem hiding this comment.
🟡 Changes recommended
Kernel reduction ignores supplied argument bindings, potentially introducing unbound parameters into reconstructed expressions, while sparse factors can trigger an AttributeError during reconstruction.
5 open issues
What changed in this PR
This PR adds syzygy-based factorization of IntG systems to reduce fast multipole method (FMM) evaluations. It provides the reduction step for the broader effort to share source computations across PDE systems; integration with kernel rewriting remains separate.
Changes:
- Convert source derivatives and densities into polynomial matrices.
- Factor matrices using kernel PDE identities and reconstruct source/target expressions.
- Add tests for the paper’s factorization example and a Laplace-system reduction.
| File | Description |
|---|---|
test/test_symbolic_reduce_fmm.py |
Tests polynomial factorization and Laplace-based reduction. |
pytential/symbolic/reduce_fmm.py |
Implements compatibility checks, polynomial conversion, factorization, and expression reconstruction. |
Review effort: Balanced
alexfikl
force-pushed
the
reduce-fmm
branch
2 times, most recently
from
November 13, 2026 19:57
b059f8c to
1b232a5
Compare
alexfikl
commented
Nov 13, 2026
alexfikl
force-pushed
the
reduce-fmm
branch
2 times, most recently
from
November 20, 2026 09:12
fee0c05 to
8f1bdc2
Compare
Co-authored-by: Alexandru Fikl <alexfikl@gmail.com> Co-authored-by: Andreas Kloeckner <inform@tiker.net>
Collaborator
Author
|
@inducer This should be good to go now. Removed the |
Owner
|
Thanks! As discussed, this looks great. In it goes. 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is another chunk of #195. It adds the syzygy-based factorization of
IntGsystems that should reduce the number of FMMs.TODO:
sumpyorpymbolic.ROADMAP:
IntGs: Reduce FMMs for PDE systems #338.rewrite_using_base_kernelintopytential.reduce_fmmswith the rewrite.cc: @isuruf
xref: #195