Repository navigation
fix(cli): guard non-array requiredElementsArray in iOS plist merge - #8703
Open
imuhammadnadeem wants to merge 1 commit into
Open
imuhammadnadeem wants to merge 1 commit into
imuhammadnadeem wants to merge 1 commit into
Conversation
Some Cordova plugin config.xml shapes parse to a non-array for required Info.plist elements. Skip those entries with a warning instead of throwing while iterating.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doesContainElementsincli/src/cordova.tswhenrequiredElementsArrayis not an array.config.xmlshapes parse to a non-array for required Info.plist elements; iterating them currently throws duringcap sync/ iOS plist merge.Context
Shipped via
patch-packageon@capacitor/cli@6.2.1in a Capacitor + Cordova hybrid app. Re-applied against current tip source (cli/src/cordova.ts).Test plan
npx cap sync ioswith normal Cordova plugins still merges Info.plist entriesedit-config/ required elements parse oddly logs the warning and continues instead of throwingMade with Cursor