Repository navigation
Build Windows Debug CI with /O2 /Ob1 - #302
Merged
Merged
Conversation
Keeps asserts and the Debug runtime's STL iterator checks but drops /RTC1, which MSVC can't combine with optimization. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds the Windows Debug CI job with
/O2 /Ob1instead of/Od /Ob0 /RTC1, following the Linux/macOS-O1change in #301. Only.github/workflows/continuous.ymlchanges.-O0to 171 s at-O1./Od: Eigen-heavy tests suffer as they did on Linux-O0, e.g.GCP rest-shape measureat 1,114 s.Point-triangle distance typetakes 403 s vs 24 s on Linux-O0, andLBVH::buildtakes 435 s vs 60 s./O2removes the first cost./Ob1still inlines Eigen's small functions but avoids the extra compile time of/Ob2.Impact:
NDEBUGstays undefined) and the STL iterator checks (Debug runtime), which are what Windows Debug catches that Linux Debug doesn't./RTC1's stack-frame and uninitialized-variable checks, since MSVC can't combine them with optimization. The ODR check job still covers the Eigen ABI stack-smashing case.main(enabled by Fix stale ccache keys and slow Debug CI tests #301) absorb this after the first push.Type of change
How Has This Been Tested?
-O0and-O1).continuous.ymlparses as YAML.Checklist