Repository navigation
Conversation
…torAggregator. Update SetSuccessStatus. Added new methods: GetDeployment, LabelsAsString. Added scale for RBAC
P0lskay
marked this pull request as ready for review
June 23, 2026 09:48
aa1ex
reviewed
Jun 24, 2026
Contributor
|
Discussed in the Telegram group, summary for the record. The current approach (scale subresource on the CR) can't work for ClusterVectorAggregator: HPA doesn't support cluster-scoped targets, so it only works for the namespaced VectorAggregator. So we're looking at a different approach: add an autoscaling block to the spec and have the operator create and manage the HPA itself, targeting the underlying Deployment. The Deployment is namespaced in both cases, so this covers both VectorAggregator and ClusterVectorAggregator. The operator would also stop setting replicas when autoscaling is on, to not compete with the HPA. This replaces the scale-subresource mechanism, so we'll likely rework the PR. |
Contributor
Author
|
Rework in #230 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solved #225
This PR implements HPA support for Vector aggregators (
VectorAggregatorandClusterVectorAggregator) by exposing thescalesubresource in their Custom Resource Definitions (CRDs).Changes
scalesubresource toVectorAggregatorandClusterVectorAggregatorCRDs to enable native Kubernetes HPA integration.SetSuccessStatusand added new helper methods (GetDeployment,LabelsAsString).scalesubresource in RBAC configurations.