Repository navigation
feat: disable pipeline optimization - #227
Merged
Merged
Conversation
…ressure isolation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config optimization (#222) collapses the
kubernetes_logssources of a signature group into one shared source. A sink stuck with the defaultbuffer.when_full: blockbackpressures that shared source and stalls every pipeline of the group (head-of-line blocking).This adds a per-pipeline opt-out: a
(Cluster)VectorPipelineannotatedvector-operator.kaasops.io/config-optimization: disabledkeeps its source standalone while the rest of the group still collapses. It is the same annotation used on the Vector CR, scoped to one pipeline. The annotation is folded into the pipeline hash so toggling it rebuilds the agent config, withomitemptyso pipelines without it keep a stable hash and are not re-validated on upgrade.It also adds an optional, off-by-default
PrometheusRule(prometheusRule.enabled) with two alerts:VectorOptimizedSourceStalled(the shared source stalled) andVectorSinkFailing(names the failing HTTP sink bycomponent_id). Both needspec.agent.internalMetrics. The trade-off, mitigations, and a pre-enable check are indocs/config-optimization.md.The feature is off by default and behavior is unchanged when no pipeline is annotated. Toggling the annotation re-reads that pipeline's namespace once; this is a live config reload, not a Secret-name change, so checkpoint migration does not cover it.