Repository navigation
Conversation
The delegate could await the response of a task whose backing Task was not set yet, which trapped on the implicitly unwrapped optional. The Task is now created first and held by a gate until the delegate returns, which keeps imageTaskCreated ahead of imageTaskDidStart.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1025.
imageTaskCreatedis called synchronously with the task, and a delegate can await the response right away, for example from aTaskit starts._taskwas still unset at that point, which trapped on the implicitly unwrapped optional.The backing
Taskis now created first and held by a small gate until the delegate returns. Without the gate,imageTaskDidStartcould run on the actor beforeimageTaskCreatedreturned, so the documented order (created, then started) would stop holding. The default delegate and data tasks skip the gate.