Skip to content

log Agent UUID at push agent startup - #1278

Merged
ansasaki merged 1 commit into
keylime:masterfrom
msafarik:push_model_log_uuid
Sep 25, 2026
Merged

ansasaki merged 1 commit into
keylime:masterfrom
msafarik:push_model_log_uuid

Conversation

@msafarik

@msafarik msafarik commented Sep 22, 2026 •

Copy link
Copy Markdown

Log the resolved push model agent UUID at startup, including when uuid = hash_ek.

This matches the pull agent log format and makes the UUID easily available to users and automation.

Resolves: keylime/keylime#1949

Summary by CodeRabbit

  • Improvements
    • The agent now logs its resolved UUID during startup, making the active identifier visible in application logs.

Signed-off-by: Marek Safarik <msafarik@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9025ab4a-fcef-4a04-8241-bad5849b4b5b

📥 Commits

Reviewing files that changed from the base of the PR and between 293d1db and 014cdd4.

📒 Files selected for processing (1)
  • keylime-push-model-agent/src/main.rs

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The push agent now logs the resolved Agent UUID after processing command-line and configuration values, including the hash_ek case.

Changes

Push agent startup

Layer / File(s) Summary
Resolved UUID logging
keylime-push-model-agent/src/main.rs
run() emits an info log containing the resolved Agent UUID before startup continues.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 014cd

The push agent logs its resolved UUID during startup, including the hash_ek case, improving operator and automation visibility without changing runtime behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: logging the resolved Agent UUID at push agent startup.
Linked Issues check ✅ Passed The PR summary states that run() logs the resolved agent UUID after UUID resolution and before registrar registration. It includes the hash_ek path and uses the required `INFO keylime_push_model_a…
Out of Scope Changes check ✅ Passed The reported change is limited to one startup log statement in keylime-push-model-agent/src/main.rs. The change directly implements #1949 and does not indicate unrelated behavior or files.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 Clippy (1.98.0)

Clippy execution failed


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.77%. Comparing base (293d1db) to head (014cdd4).

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 38.82% <0.00%> (-0.01%) ⬇️
upstream-unit-tests 65.71% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime-push-model-agent/src/main.rs 25.15% <100.00%> (+0.46%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansasaki ansasaki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansasaki
ansasaki merged commit 54c62fa into keylime:master Sep 25, 2026
14 of 17 checks passed
@ansasaki ansasaki mentioned this pull request Sep 30, 2026
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFE: log Agent UUID at push agent startup

2 participants