Repository navigation
refactor(reader): rename page isolation to solo naming - #1233
Merged
Merged
Conversation
everpcpc
force-pushed
the
refactor/page-solo-naming
branch
from
October 9, 2026 05:08
9b9054d to
433c62b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the page "isolation" vocabulary to solo throughout the app, matching what the feature actually does: a solo page is not paired with its neighbor in dual-page mode.
UI strings (English source):
Isolate→Show SoloCancel Isolation→Cancel SoloIsolate Page %d→Show Page %d SoloIsolate Cover Page→Solo Cover Page(the dual-page cover preference, DIVINA and PDF)All 10 supported languages re-translated; zh-Hans/zh-Hant/ja/ko keep their existing (already correct) "show alone" wording. The revert action is
Cancel Solorather than a "show paired" phrasing because un-soloing does not guarantee the page pairs (its neighbor may also be solo, or dual-page mode may be off).Code symbols renamed end to end:
ReaderPageIsolationActions→ReaderPageSoloActions,toggleIsolatePage→toggleSoloPage,isPageIsolated/isCurrentPageIsolated→isPageSolo/isCurrentPageSolo,supportsPageIsolationActions→supportsPageSoloActions,canIsolatePageFromCurrentPresentation→canSoloPageFromCurrentPresentation,isolateCoverPage/pdfIsolateCoverPage→soloCoverPage/pdfSoloCoverPage,fetchIsolatePages/updateIsolatePages→fetchSoloPages/updateSoloPages, and the fileReaderPageSoloActions.swift.Persisted names intentionally kept, with a note at each site:
isolate_pages_raw— renaming it would buy nothing but a migration.isolateCoverPage/pdfIsolateCoverPage— renaming them would silently reset existing users' preferences.Why
"Isolate" reads as exclusion or export (quarantine the page, take it out of the book), which is misleading — the page stays right where it is, it just shows alone instead of paired. The misleading source string already propagated: de/es/it/ru translated it as quarantine vocabulary, while zh/ja/ko/fr were translated by actual behavior ("show alone"). Aligning the source string with the behavior fixes both halves.
Validation
make formatmake build— iOS, macOS, tvOS all built successfullymake localize+./misc/translate.py list→ no missing translations; the five replaced keys were removed withtranslate.py removeisolatesymbol/string reference was renamed (repo-wide grep), including the title-compare sites and the macOS menu selectors.Includes
make bumpto build 642.Also fixes the root cause of recurring
extractionState: stalechurn on "Enter Offline Mode":ServerViewandServerCardViewbuilt their label with a ternary insideString(localized:), which the strings extractor cannot resolve statically. Both call sites now hoist the branch outside the localized call so every key is a static literal — verified thatmake localizeno longer flags the key.