Repository navigation
Fix database_exists() for named in-memory SQLite URIs - #840
Open
Cherith1222 wants to merge 1 commit into
Open
Cherith1222 wants to merge 1 commit into
Cherith1222 wants to merge 1 commit into
Conversation
A file URI with mode=memory has no filesystem path, so the check reported it missing. (kvesteri#542) AI-assisted (Cursor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
database_exists()treated a named in-memory SQLite URI (file:name?mode=memory&uri=true) as a filesystem path, so the check in #542 did not succeed.:memory:and an omitted database name already count as existing. This applies the same result when the database name is afile:URI, SQLAlchemy URI mode is on, and SQLite'smodeismemory.Fixes #542
Cherith reviewed this diff and confirmed it with the person who helped draft it.
Drafted with Cursor. Model: Grok 4.7.