Repository navigation
experiment: reduce PROP annotatons using local bi - #724
Merged
Merged
Conversation
Collaborator
Author
|
!bench |
|
Benchmark results for 1d3761a against 9a4ae0d are in. No significant results found. @markusdemedeiros
Small changes (1✅)
|
| namespace MonoList | ||
|
|
||
| variable {GF : BundledGFunctors} {α : Type _} [MonoListG GF α] | ||
| local bi IProp GF |
Collaborator
There was a problem hiding this comment.
This looks a bit like local bi takes two arguments. Can we change the notation to force the user to write local bi (IProp GF) instead?
Collaborator
|
@markusdemedeiros You pinged me to review this PR, but it is still marked as a draft. Do you want me to review it now? |
Collaborator
Author
|
@lzy0505 Yes, if you're able. |
markusdemedeiros
marked this pull request as ready for review
October 26, 2026 11:54
Collaborator
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One of the experiments mentioned in #723 .
Checklist
authorssection of any appropriate files.