Repository navigation
chore: update bench suite - #728
Merged
MackieLoeffel merged 5 commits intoOct 27, 2026
Merged
Conversation
Contributor
Author
|
!bench |
|
Benchmark results for 4fb28a9 against 3f808f5 are in. There are significant results. @Garmelon
Large changes (1✅)
Small changes (241✅)
|
Collaborator
|
Thanks for the PR! One brief question: The description says "adds support for precompilation", but I don't see anything related to that in this PR. Do I miss something or is something missing from this PR? (Or is this referring to the changes in #722?) |
Contributor
Author
|
I meant that after this PR, the bench suite no longer crashes when you try to use pre compilation. #722 had to include the same changes in order not to crash the bench suite. |
Contributor
Author
|
Now that I'm looking more closely, looks like I missed exactly those changes in this PR. One moment |
Contributor
Author
|
!bench |
|
Benchmark results for 984c5ba against 3f808f5 are in. There are significant results. @Garmelon
Large changes (1✅)
Small changes (242✅)
|
Collaborator
|
Perfect, thanks! Merging. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the benchmark suite back into alignment with the other ones. It fixes how wall-clock and how maxrss are measured, and adds support for precompilation (which will be used by #722).