Skip to content

feat(Mathematics): The adjoint on su(n). - #1744

Merged
jstoobysmith merged 6 commits into
leanprover-community:masterfrom
jstoobysmith:SUnAdjiont
Oct 7, 2026
Merged

jstoobysmith merged 6 commits into
leanprover-community:masterfrom
jstoobysmith:SUnAdjiont

Conversation

@jstoobysmith

Copy link
Copy Markdown
Member

Results related to the adjoint representation of su(n). This is based of the material in #1415.

@github-actions github-actions Bot added the large label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

  1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

  2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

  3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages.

If you have any problems or questions, please reach out to the community on the Zulip.

@github-actions github-actions Bot added the t-mathematics Mathematics label Oct 6, 2026
@nateabr

nateabr commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

claim

@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Review claim by @nateabr completed — thanks for the review.

@nateabr

nateabr commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

@jstoobysmith is this ready to review?

awaiting-author

@github-actions github-actions Bot added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 6, 2026
@jstoobysmith

Copy link
Copy Markdown
Member Author

@nateabr yep, this is now ready :)

@jstoobysmith

Copy link
Copy Markdown
Member Author

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 6, 2026

@nateabr nateabr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added some comments

Comment thread Physlib/Mathematics/Groups/SpecialUnitary/LieAlgebra/Basic.lean Outdated
Comment thread Physlib/Mathematics/Groups/SpecialUnitary/LieAlgebra/Adjoint.lean Outdated
Comment thread Physlib/Mathematics/Groups/SpecialUnitary/LieAlgebra/Basic.lean

/-- The contraction is the Killing form on the complexified Lie
algebra, up to a factor of `-1/(2n)`. -/
lemma adjointℂContr_eq_killingForm {n : ℕ} (A B : Complexification n) :

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this proof should be split into two steps. What we can do is extract the matrix trace part and then prove the hK as a lemma and the current inverse factor can be a corollary.

The killing form proof would read better if it's just the application to the lie algebra

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I have done this, although am not 100% sure what you mean here.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poor comment from me :(

You have addressed my comment though. I had also asked additionally to maybe extract computing the trace of the operator M ↦ −[A, [B, M]] on all matrices, before using that A and B are traceless.

Though this is not needed as the equivTraceKer makes everything very clear

@nateabr

nateabr commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

awaiting-author

@github-actions github-actions Bot added awaiting-author A reviewer has asked the author a question or requested changes and removed review-claimed labels Oct 6, 2026
@jstoobysmith

Copy link
Copy Markdown
Member Author

@nateabr addressed comments

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 7, 2026

@nateabr nateabr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes. Approved


/-- The contraction is the Killing form on the complexified Lie
algebra, up to a factor of `-1/(2n)`. -/
lemma adjointℂContr_eq_killingForm {n : ℕ} (A B : Complexification n) :

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poor comment from me :(

You have addressed my comment though. I had also asked additionally to maybe extract computing the trace of the operator M ↦ −[A, [B, M]] on all matrices, before using that A and B are traceless.

Though this is not needed as the equivTraceKer makes everything very clear

@jstoobysmith
jstoobysmith added this pull request to the merge queue Oct 7, 2026
@jstoobysmith jstoobysmith added ready-to-merge This PR is approved and will be merged shortly and removed reviewer-approved labels Oct 7, 2026
Merged via the queue into leanprover-community:master with commit 672c025 Oct 7, 2026
12 checks passed
@jstoobysmith
jstoobysmith deleted the SUnAdjiont branch October 7, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large ready-to-merge This PR is approved and will be merged shortly t-mathematics Mathematics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants