Resize QTI images at publish to their authored size - #6219
Merged
rtibbles merged 2 commits intoOct 2, 2026
Merged
Conversation
rtibblesbot
force-pushed
the
issue-6189-ddc7c9
branch
from
September 30, 2026 16:07
c66e4ed to
65455bc
Compare
Contributor
Author
|
Outside this PR's scope — tracked under #5998:
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly How was this generated?
|
rtibblesbot
force-pushed
the
issue-6189-ddc7c9
branch
from
September 30, 2026 19:11
65455bc to
b99cf06
Compare
rtibblesbot
marked this pull request as ready for review
September 30, 2026 22:53
rtibblesbot
force-pushed
the
issue-6189-ddc7c9
branch
2 times, most recently
from
October 1, 2026 21:43
d7d0b26 to
138c5e3
Compare
- Animated GIFs resize every frame, keeping timing and loop; at natural size the original ships. - Past MAX_RESIZED_IMAGE_PIXELS the original ships. - EXIF-rotated photos come out upright; JPEGs keep their ICC profile. - Same-size re-encodes ship only when smaller than the original. - Sized SVGs get root width/height (and a viewBox when missing). - A failed resize ships the original instead of a dangling reference. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- Sized <img> (integer width and height) ship a resized copy per size in the QTI package; width/height stay in the XML. - Rewrites go per element, so one image at two sizes ships two files. - Derived Perseus markdown carries ` =WxH`, so publish resizes and fills the images map. - Legacy items keep the size on their QTI <img>. Refs learningequality#6189 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
rtibblesbot
force-pushed
the
issue-6189-ddc7c9
branch
from
October 2, 2026 04:58
138c5e3 to
74880f0
Compare
rtibbles
reviewed
Oct 2, 2026
rtibbles
left a comment
rtibbles
left a comment
Member
There was a problem hiding this comment.
General read through looks correct, and the tests cover the cases. Will do a quick manual check before approving - and just one thought for follow up.
| ) | ||
|
|
||
|
|
||
| def img_pixel_size(width, height) -> Optional[Tuple[int, int]]: |
Member
There was a problem hiding this comment.
I don't think we need to handle it now, because the frontend editor doesn't produce it - but would be good to file a follow up issue for srcset handling here.
Contributor
Author
There was a problem hiding this comment.
Outside this PR's scope — tracked as #6278 under #5998.
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
- Ran pre-flight CI checks (lint, format, tests) and verified all pass
- Rebased onto the target branch and resolved any conflicts
- Reorganized commit history into clean, logical commits
- Audited the diff to ensure only issue-relevant files are changed
- Built PR body from the repository's PR template with evidence blocks
3 tasks
rtibbles
approved these changes
Oct 2, 2026
rtibbles
left a comment
rtibbles
left a comment
Member
There was a problem hiding this comment.
Did some local QA and the image resizing worked in QTI exercises as intended.
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<img>ships a resized copy per size in the QTI package and the derived Perseus archive.width/height; Perseus markdown gets=WxHand a filledimagesmap.References
Refs #6189. Refs #6213. Refs #6215 (overlaps #6216). Kolibri display: learningequality/kolibri#15383.
Reviewer guidance
Legacy publish output changes:
width/height(and aviewBoxwhen missing).MAX_ANIMATED_IMAGE_PIXELSship the original.<img>in the QTI package now carrieswidth/height.Open risk:
<img>tags are rewritten; a foreign package using a namespace prefix ships full-size files.Deviations from the issue spec
AI usage
Used Claude Code to plan and implement the publish-time resize and its tests. Verified with the
tests/utils/suite and pre-commit.🤖 Generated with Claude Code
@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly
How was this generated?
🟡 Waiting for feedback
Last updated: 2026-10-02 17:18 UTC