Repository navigation
Ceremony: add enforcement of acceptable revocation dates and reasons - #9136
Merged
Merged
Conversation
ezekiel
previously approved these changes
Oct 29, 2026
ezekiel
requested review from
a team and
beautifulentropy
and removed request for
a team and
beautifulentropy
October 29, 2026 19:49
beautifulentropy
self-requested a review
October 29, 2026 20:02
beautifulentropy
requested changes
Oct 29, 2026
beautifulentropy
approved these changes
Oct 29, 2026
ezekiel
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new checks to our CRL ceremony tool:
These checks ensure that our ceremony-produced CRLs comply with the profiles in Section 7.2 of v6.3 of our CP/CPS (https://letsencrypt.org/documents/isrg-cp-cps-v6.3/#7.2-crl-profile). They are belt-and-suspenders checks; they are also checked by the lints in #9129.
Also, update both the crlCeremony and generateCRL functions to build their respective RevocationListEntry and RevocationList objects once all values are prepared, rather than constructing them halfway and then assigning to additional fields afterwards.