Skip to content

Add kata-get-params and kata-set-params to known GTP commands - #1263

Open
Slymaster wants to merge 1 commit into
lightvector:masterfrom
Slymaster:gtp-known-params-commands
Open

Slymaster wants to merge 1 commit into
lightvector:masterfrom
Slymaster:gtp-known-params-commands

Conversation

@Slymaster

Copy link
Copy Markdown

kata-get-params and kata-set-params are documented in GTP_Extensions.md and work, but they were never added to knownCommands in gtp.cpp. So known_command kata-get-params returns false and neither command shows up in list_commands, which matters for controllers that check support before sending a command.

I added both names next to kata-get-param and kata-set-param, and added two known_command lines to tests/gtp/misc.txt with the matching expected output. I checked this on the Eigen backend on macOS; apart from the backend-specific lines, the misc GTP test output matches the committed results.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant