Repository navigation
Conversation
CSS's parser closes what is still open at the end of its input, so rgb(0, 255, 0 is green in browsers and in their canvas's fillStyle. A closing parenthesis is still required before anything else.
lehni
force-pushed
the
fix/css-color-unclosed
branch
from
October 21, 2026 21:37
0916dc8 to
7e06783
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS's parser closes what is still open at the end of its input, so
rgb(0, 255, 0is green in browsers, in a canvas'sfillStyletoo: the end of the string now closes a color function, while a missing)before anything else is still an error. Found with the web-platform-tests' canvas colour tests (2d.fillStyle.parse.rgb-eof,rgba-eof). With a test.