Skip to content

blk-cgroup: show io.stat numbers for discard-only cgroups - #1217

Closed
ghost wants to merge 1 commit into
linus-master_basefrom
series/1157655=>linus-master
Closed

ghost wants to merge 1 commit into
linus-master_basefrom
series/1157655=>linus-master

Conversation

@ghost

@ghost ghost commented Sep 4, 2026

Copy link
Copy Markdown

Pull request for series with
subject: blk-cgroup: show io.stat numbers for discard-only cgroups
version: 2
url: https://patchwork.kernel.org/project/linux-block/list/?series=1157655

@ghost

ghost commented Sep 4, 2026

Copy link
Copy Markdown
Author

Upstream branch: bc35965
series: https://patchwork.kernel.org/project/linux-block/list/?series=1157655
version: 2

@ghost
ghost force-pushed the linus-master_base branch from 8242bf1 to 5b28f57 Compare September 7, 2026 02:54
@ghost

ghost commented Sep 7, 2026

Copy link
Copy Markdown
Author

Upstream branch: df29080
series: https://patchwork.kernel.org/project/linux-block/list/?series=1157655
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from 682e816 to 7dc65a8 Compare September 7, 2026 04:28
@ghost ghost closed this Sep 7, 2026
@ghost ghost reopened this Sep 8, 2026
@ghost

ghost commented Sep 8, 2026

Copy link
Copy Markdown
Author

Upstream branch: 28924df
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from 7dc65a8 to d3078c1 Compare September 8, 2026 15:29
@ghost
ghost force-pushed the linus-master_base branch from 4ddd216 to 00cc4ca Compare September 9, 2026 07:40
@ghost

ghost commented Sep 9, 2026

Copy link
Copy Markdown
Author

Upstream branch: 893e117
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from d3078c1 to beb8049 Compare September 9, 2026 07:49
@ghost
ghost force-pushed the linus-master_base branch from 00cc4ca to 7efd8cd Compare September 10, 2026 15:29
@ghost

ghost commented Sep 10, 2026

Copy link
Copy Markdown
Author

Upstream branch: 50d05c7
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from beb8049 to e4529d7 Compare September 10, 2026 15:34
@ghost
ghost force-pushed the linus-master_base branch from 7efd8cd to a0aeca9 Compare September 12, 2026 02:26
@ghost

ghost commented Sep 12, 2026

Copy link
Copy Markdown
Author

Upstream branch: 5225b8e
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from e4529d7 to 63220ee Compare September 12, 2026 02:44
@ghost ghost added the V2-ci-pass label Sep 12, 2026
@ghost
ghost force-pushed the linus-master_base branch from a0aeca9 to 772381e Compare September 13, 2026 08:50
@ghost

ghost commented Sep 13, 2026

Copy link
Copy Markdown
Author

Upstream branch: 2f0c1cf
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from 63220ee to b68f5e5 Compare September 13, 2026 10:13
@ghost
ghost force-pushed the linus-master_base branch from 772381e to 0224dee Compare September 13, 2026 22:56
@ghost

ghost commented Sep 13, 2026

Copy link
Copy Markdown
Author

Upstream branch: 2f0c1cf
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from b68f5e5 to 83683ef Compare September 13, 2026 23:14
@ghost
ghost force-pushed the linus-master_base branch from 0224dee to f14340f Compare September 15, 2026 09:28
@ghost

ghost commented Sep 15, 2026

Copy link
Copy Markdown
Author

Upstream branch: 5878583
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from 83683ef to 8ac9f52 Compare September 15, 2026 09:50
@ghost
ghost force-pushed the series/1157655=>linus-master branch from 61d1267 to 7c99a47 Compare September 24, 2026 08:11
@ghost
ghost force-pushed the linus-master_base branch from 2414e80 to 38f4bbb Compare September 24, 2026 14:23
@ghost

ghost commented Sep 24, 2026

Copy link
Copy Markdown
Author

Upstream branch: f49a343
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from 7c99a47 to 9452d9a Compare September 24, 2026 15:19
@ghost ghost added V2-ci-fail and removed V2-ci-pass labels Sep 25, 2026
@ghost
ghost force-pushed the linus-master_base branch from 38f4bbb to 372fcdc Compare September 26, 2026 07:53
@ghost

ghost commented Sep 26, 2026

Copy link
Copy Markdown
Author

Upstream branch: 6812ce4
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from 9452d9a to 8b46a5b Compare September 26, 2026 08:36
@ghost
ghost force-pushed the linus-master_base branch from 372fcdc to c6537fe Compare September 28, 2026 14:39
@ghost

ghost commented Sep 28, 2026

Copy link
Copy Markdown
Author

Upstream branch: 72d3fcf
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from 8b46a5b to b6cb057 Compare September 28, 2026 15:27
@ghost ghost added V2-ci-pass and removed V2-ci-fail labels Sep 29, 2026
@ghost
ghost force-pushed the linus-master_base branch from c6537fe to eebb5bc Compare October 1, 2026 15:18
@ghost

ghost commented Oct 1, 2026

Copy link
Copy Markdown
Author

Upstream branch: 551c722
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from b6cb057 to 1d984ac Compare October 1, 2026 16:57
@ghost
ghost force-pushed the linus-master_base branch from eebb5bc to bbd3af0 Compare October 1, 2026 23:18
@ghost

ghost commented Oct 1, 2026

Copy link
Copy Markdown
Author

Upstream branch: ce1e022
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from 1d984ac to 965a098 Compare October 1, 2026 23:59
@ghost
ghost force-pushed the linus-master_base branch from bbd3af0 to a9c0b46 Compare October 3, 2026 09:37
@ghost

ghost commented Oct 3, 2026

Copy link
Copy Markdown
Author

Upstream branch: e767a4e
series: https://patchwork.kernel.org/series/1157655/
version: 2

@ghost
ghost force-pushed the series/1157655=>linus-master branch from 965a098 to c6d55ee Compare October 3, 2026 10:22
@ghost
ghost force-pushed the linus-master_base branch from a9c0b46 to 72d0f5e Compare October 3, 2026 21:50
@ghost

ghost commented Oct 3, 2026

Copy link
Copy Markdown
Author

Upstream branch: a74306e
series: https://patchwork.kernel.org/series/1157655/
version: 2

blkcg_print_one_stat() gates the rbytes/wbytes/rios/wios/dbytes/dios
output on

    if (rbytes || wbytes || rios || wios)

which omits the discard counters.  A cgroup that has issued only discards
(zero read and write counters) therefore prints an empty stat line and its
dbytes/dios are never surfaced, even though they are accounted correctly.

The guard predates the addition of discard stats and was never updated;
include dbytes/dios so discard-only cgroups are reported.

Fixes: 636620b ("blkcg: Track DISCARD statistics and output them in cgroup io.stat")
Signed-off-by: Tao Cui <cuitao@kylinos.cn>
Reviewed-by: Tang Yizhou <yizhou.tang@shopee.com>
@ghost
ghost force-pushed the series/1157655=>linus-master branch from c6d55ee to b3fe4bb Compare October 3, 2026 22:31
@ghost

ghost commented Oct 4, 2026

Copy link
Copy Markdown
Author

At least one diff in series https://patchwork.kernel.org/series/1157655/ irrelevant now for [{'archived': False, 'project': 241}] search patterns

@ghost ghost closed this Oct 4, 2026
@ghost
ghost deleted the series/1157655=>linus-master branch October 6, 2026 08:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants