Repository navigation
Conversation
1. Root cause: QFileIconProvider depends on the system icon theme which lacks entries for jar and tar.bz2, returning empty icons 2. Fix: add UiTools::getArchiveIcon() with three-level fallback: QFileIconProvider -> QMimeDatabase/QIcon::fromTheme -> generic archive icon; replace both call sites in compresssettingpage and progresspage 3. Impact: jar and tar.bz2 archive icons now display correctly in preview and progress pages; no behavior change for other formats Log: Fix archive icon not showing for jar and tar.bz2 formats Influence: 1. Test jar format compression preview icon display 2. Test tar.bz2 format compression preview icon display 3. Test zip, 7z, tar.gz formats still display correctly 4. Verify archive icon on progress page after compression fix: 修复jar和tar.bz2压缩格式图标不显示问题 1. 根因：QFileIconProvider 依赖系统图标主题，jar 和 tar.bz2 格式 缺少对应图标资源导致返回空图标 2. 方案：新增 UiTools::getArchiveIcon() 三级回退方法： QFileIconProvider → QMimeDatabase/QIcon::fromTheme → 通用 压缩包图标，替换压缩设置页和进度页两处调用点 3. 影响：jar 和 tar.bz2 压缩格式图标恢复正常显示，其他格式 无行为变化 Log: 修复jar和tar.bz2压缩格式图标不显示问题 Influence: 1. 测试jar格式压缩时预览图标显示 2. 测试tar.bz2格式压缩时预览图标显示 3. 测试zip、7z、tar.gz格式图标显示正常无回归 4. 验证压缩完成后进度页文件图标显示 PMS: BUG-378903
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThe PR fixes missing jar and tar.bz2 icons by replacing direct QFileIconProvider calls with a shared UiTools helper that falls back through MIME theme resolution to a generic archive icon, covering both compression preview and progress pages. Sequence diagram for archive icon fallback resolutionsequenceDiagram
participant Page as CompressionPage
participant UiTools
participant FileIcons as QFileIconProvider
participant MimeDB as QMimeDatabase
participant Theme as QIconTheme
Page->>UiTools: getArchiveIcon(fileName)
UiTools->>FileIcons: icon(QFileInfo(fileName))
alt icon available
FileIcons-->>UiTools: archive icon
else icon missing
UiTools->>MimeDB: mimeTypeForFile(fileName, MatchExtension)
MimeDB-->>UiTools: QMimeType.iconName()
UiTools->>Theme: fromTheme(iconName)
alt MIME icon available
Theme-->>UiTools: MIME archive icon
else MIME icon missing
UiTools->>Theme: fromTheme(application-x-archive)
Theme-->>UiTools: generic archive icon
end
end
UiTools-->>Page: QIcon
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 语法正确，逻辑清晰。三级回退机制（QFileIconProvider → QMimeDatabase → 通用归档图标）设计合理，icon.isNull() 与 icon.availableSizes().isEmpty() 双重检查确保图标有效性。 2. 代码质量 ✅评价： 良好 ✅ 通过 潜在问题：
建议： 代码结构清晰，注释完整。建议在 release 构建中通过 Qt 日志级别控制减少 qDebug 输出，或使用 QtLoggingCategory 按模块控制日志级别。 3. 代码性能 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 性能良好，资源使用合理。QFileIconProvider 和 QMimeDatabase 均为栈对象，生命周期短，不会造成资源泄漏。三级回退按效率从高到低排列，仅在必要时触发后续回退。QIcon 返回值利用 Qt 隐式共享机制，无额外拷贝开销。 4. 代码安全 🔒评价： 优秀 ✅ 通过
安全漏洞详情： 建议： 存在0个安全漏洞。代码仅涉及图标查询操作，无文件读写、网络请求或命令执行，无安全风险。 💡 改进建议代码示例// 建议使用 QLoggingCategory 控制工具函数日志级别
#include <QLoggingCategory>
Q_LOGGING_CATEGORY(uiToolsCategory, "uitools", QtWarningMsg)
QIcon UiTools::getArchiveIcon(const QString &fileName)
{
qCDebug(uiToolsCategory) << "Getting archive icon for:" << fileName;
QFileIconProvider provider;
QIcon icon = provider.icon(QFileInfo(fileName));
if (icon.isNull() || icon.availableSizes().isEmpty()) {
QMimeDatabase mimeDb;
QMimeType mimeType = mimeDb.mimeTypeForFile(fileName, QMimeDatabase::MatchExtension);
QString iconName = mimeType.iconName();
if (!iconName.isEmpty()) {
icon = QIcon::fromTheme(iconName);
}
}
if (icon.isNull() || icon.availableSizes().isEmpty()) {
icon = QIcon::fromTheme(QStringLiteral("application-x-archive"));
}
return icon;
}本报告由 AI 代码审查工具自动生成 |
Contributor
|
TAG Bot New tag: 6.5.36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: archive icon missing for jar and tar.bz2
which lacks entries for jar and tar.bz2, returning empty icons
QFileIconProvider -> QMimeDatabase/QIcon::fromTheme -> generic
archive icon; replace both call sites in compresssettingpage
and progresspage
preview and progress pages; no behavior change for other formats
Log: Fix archive icon not showing for jar and tar.bz2 formats
Influence:
fix: 修复jar和tar.bz2压缩格式图标不显示问题
缺少对应图标资源导致返回空图标
QFileIconProvider → QMimeDatabase/QIcon::fromTheme → 通用
压缩包图标，替换压缩设置页和进度页两处调用点
无行为变化
Log: 修复jar和tar.bz2压缩格式图标不显示问题
Influence:
PMS: BUG-378903
Summary by Sourcery
Ensure archive icons display consistently in compression preview and progress pages.
Bug Fixes:
Enhancements: