Repository navigation
Org-import copies only EasyCLA roles onto an existing Account #5081, E2E fixes - prod - #5315
Conversation
…E2E fixes - prod Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot) Assisted by [Claude](https://claude.ai)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
@lukaszgryglicki I'm starting review 1 of this pull request now (started 2026-11-18 12:30 UTC using review agent v0.1.34). This usually takes a few minutes. I'll update this comment with the summary when I'm done. If there's no summary here after about 45 minutes, the review stopped: push a new commit, or post a comment that begins with a mention of me followed by Hi Łukasz, SummaryThis pull request makes Decision✅ Approved with minor comments 🟡 1 minor · ❔ 1 question DetailsOverall impression: The grant-policy change is well scoped. 🟡 Minor: 1 issue: Dropped-grant usernames are lost when a rewrite apply runs with notify off ❔ Question: 1 item: Journals written before this change replay as an existing Account Other reviewers and CI checks: CodeRabbit skipped this pull request because the base branch is not the default branch. The required check Documentation reminder: changed Rule files: read Questions, problems, or feedback: https://github.com/linuxfoundation/lfx-review-agent/issues |
lfx-one
left a comment
There was a problem hiding this comment.
No blocking findings. One minor finding and one question are left inline; neither blocks approval.
Documentation
This pull request changes behavior that may also be described outside this repository, such as product pages or an external docs site. I can't read those, so please check them; the author and maintainers own those updates. Changed here:
dropped_grants.csv(new report file written by an apply)EasyCLA-only role copy onto an existing Account(behavior change in org-import)E2E token minting through utils/get_lfx_token.sh(changed)
There was a problem hiding this comment.
🟡 Changes recommended
Interrupted and legacy rewrite replays can retain elevated access or delete required grants, and audit, privacy, and test issues remain unresolved.
7 open issues
Reconcile copied grants when the account policy changes · New Recover legacy journals without deleting grants · New Persist grant-to-user mappings across interrupted report delivery · New Redact usernames from organization-service client logs · New Journal grant deletions and report confirmed cleanup results · New Restrict the retirement exception to v1 consoles · New Install Chromium even when the Playwright package is present · New
What changed in this PR
Updates EasyCLA’s organization-import tool for the role-transfer policy in lfx-self-serve#5081, alongside E2E authentication and Self Serve company-lens updates.
Changes:
- Limits transfers onto existing or shared Accounts to five EasyCLA roles; dedicated newly created Accounts retain all grants.
- Adds grant-policy journal fields, dropped-grant reports, documentation, and regression tests.
- Switches E2E token minting to device-code login and refresh, updates company-lens checks, and handles retired-console login errors.
| File | Description |
|---|---|
tests/e2e/secrets/README.md |
Documents device-code credentials and refresh-token storage. |
tests/e2e/README.md |
Updates token-minting prerequisites. |
tests/e2e/lib/token.sh |
Adds device-code login and refresh-token reuse. |
tests/e2e/browser/ss_identity.mjs |
Recognizes the company-selector placeholder. |
tests/e2e/browser/m3_chain.mjs |
Includes company-lens navigation links. |
tests/e2e/browser/lib/m3.mjs |
Closes overlays before opening agreement details. |
tests/e2e/browser/lib/e2e.mjs |
Updates selector placeholders and backdrop handling. |
tests/e2e/browser/consoles.mjs |
Adds handling for rejected Auth0 console logins. |
tests/e2e/browser/bridge.mjs |
Supports company-lens navigation and denial checks. |
cla-backend-go/v2/company/create_company_member_service.go |
Corrects comment punctuation only. |
cla-backend-go/orgimport/steps.go |
Filters copied roles and tracks uncopied grants. |
cla-backend-go/orgimport/state.go |
Stores grant policy and dropped-grant metadata. |
cla-backend-go/orgimport/run.go |
Selects grant policy and carries it through replay. |
cla-backend-go/orgimport/run_test.go |
Updates role fixtures and deletion-failure support. |
cla-backend-go/orgimport/report.go |
Includes the dropped-grant CSV in report attachments. |
cla-backend-go/orgimport/orgimport.go |
Adds grant-policy and dropped-grant group fields. |
cla-backend-go/orgimport/grants_test.go |
Tests filtering, collapse, replay, and reporting behavior. |
cla-backend-go/orgimport/decisions.go |
Detects Accounts shared with other groups or rows. |
cla-backend-go/orgimport/columns.go |
Documents role filtering and dropped-report columns. |
cla-backend-go/orgimport/columns_test.go |
Extends report-column coverage. |
cla-backend-go/orgimport/audit.go |
Generates apply-only dropped-grant reports. |
cla-backend-go/orgimport/account_forms_test.go |
Uses EasyCLA roles in existing grant-safety tests. |
cla-backend-go/cmd/org_import/README.md |
Documents transfer policy, reports, and operational handling. |
.github/workflows/org-import-sweep.yml |
Excludes the username-bearing CSV from uploaded artifacts. |
Review effort: Balanced


linuxfoundation/lfx-self-serve#5081
cc @mlehotskylf @ahmedomosanya
org-import- on a rewrite onto an Account that existed before (matched, or several old ids under a collapse decision) onlycla-manager,cla-manager-designee,cla-signatory,contributorandcontactare copied.company-admin/viewer(and any other role) are deleted with the old id and listed in the newdropped_grants.csv(apply only: old id, target Account, user, role, scope) and inrun.log.An Account created for one group alone (
created) still gets every grant - the choice is kept in the state journal (all_grants), so a replay after a crash follows the same policy.Also
tests/e2e: tokens are minted throughutils/get_lfx_token.sh, the browser checks follow the Self Serve company lens (linuxfoundation/lfx-self-serve#5185), the v1 Corporate Console login is skipped once its Auth0 application refuses logins.Tested: unit tests (the new
grants_test.gocases formatched/created/ collapse / replay fail on thedevsources),-race, lint,devdry runs of the tool formatched/created/ collapse, E2E browser modules ondev(127 pass, 0 fail) andprod(80 pass, 0 fail).Signed-off-by: Łukasz Gryglicki lgryglicki@cncf.io
Assisted by OpenAI
Assisted by GitHub Copilot
Assisted by Claude