Repository navigation
Conversation
This was referenced Mar 3, 2024
aaqilniz
force-pushed
the
feat/strict-mode
branch
from
March 3, 2024 16:49
00952af to
aa837f6
Compare
aaqilniz
force-pushed
the
feat/strict-mode
branch
5 times, most recently
from
April 13, 2024 16:36
cfccab3 to
bbda55f
Compare
aaqilniz
marked this pull request as ready for review
April 13, 2024 17:03
aaqilniz
force-pushed
the
feat/strict-mode
branch
7 times, most recently
from
April 14, 2024 06:01
0cce059 to
26608c8
Compare
aaqilniz
marked this pull request as draft
October 25, 2026 10:19
aaqilniz
force-pushed
the
feat/strict-mode
branch
from
October 25, 2026 15:07
26608c8 to
0993d13
Compare
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
aaqilniz
force-pushed
the
feat/strict-mode
branch
from
October 25, 2026 15:07
0993d13 to
cb35b0e
Compare
aaqilniz
marked this pull request as ready for review
October 25, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a driver-level query method (
buildQueryIsStrict) to detect whether the target MySQL instance or session has strict mode enabled.##Purpose and Context:
The purpose of this PR is to provide an underlying query method for
loopback-connectorand then ultimately forloopback-datasource-jugglerto determine if strict mode is enabled.When strict mode is enabled, the model discover generator would add jsonSchema.maxLength to model properties to provide validation.
Related Issue:
jsonSchema.maxLengthalongsidelengthto support strict-mode validation loopback-next#11869Related PRs:
Checklist
npm testpasses on your machine