Skip to content

Add 303.4-303.6: galaxy morphology classification, clustering, and stellar mass regression - #229

Merged
garrethmartin merged 15 commits into
mainfrom
tickets/DM-56309
Nov 6, 2026
Merged

garrethmartin merged 15 commits into
mainfrom
tickets/DM-56309

Conversation

@garrethmartin

Copy link
Copy Markdown
Contributor

No description provided.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,626 @@
{

@shenmingfu shenmingfu Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest mentioning "RandomForest" at the introduction (i.e. specify the regressor used in this notebook at the beginning).


Reply via ReviewNB

@@ -0,0 +1,626 @@
{

@shenmingfu shenmingfu Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest mentioning that "+ structural" gives less scatter (consistent with the RMSE test above).


Reply via ReviewNB

@@ -0,0 +1,626 @@
{

@shenmingfu shenmingfu Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest mentioning "the better of the two models" is actually "color + magnitude + redshift + structural" since it's using "model_all", just for clarification.


Reply via ReviewNB

@shenmingfu shenmingfu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left some comments on the wording. I will approve the PR.

@garrethmartin
garrethmartin merged commit f697a83 into main Nov 6, 2026
2 checks passed
@garrethmartin
garrethmartin deleted the tickets/DM-56309 branch November 6, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants