Skip to content

u/mlg/2026-10-28: review new prompt 308 1 tutorial NB - #238

Merged
sgreenstreet merged 2 commits into
tickets/DM-56853from
u/mlg/2026-10-28/review-prompt-308-1
Oct 28, 2026
Merged

sgreenstreet merged 2 commits into
tickets/DM-56853from
u/mlg/2026-10-28/review-prompt-308-1

Conversation

@MelissaGraham

Copy link
Copy Markdown
Contributor

Minor changes:

  • update the header
  • for tutorials, easiest to just say container large, even if small works
  • this tutorial runs fine with the recommended
  • raised and highlighted the "proprietary" banner
  • all code cell changes are for flake8-nb compliance
  • one flake8-nb request remains unfixable but I think it's fine

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sgreenstreet sgreenstreet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this looks good. I also made edits on this branch to address Mario's comments on the tickets/DM-56583 branch.

@sgreenstreet
sgreenstreet merged commit c70895a into tickets/DM-56853 Oct 28, 2026
2 checks passed
@sgreenstreet
sgreenstreet deleted the u/mlg/2026-10-28/review-prompt-308-1 branch October 28, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants